Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Updates Mongo to 4.2 (LLC-234) #1541

Merged
merged 4 commits into from
Jul 22, 2020
Merged

fix(deps): Updates Mongo to 4.2 (LLC-234) #1541

merged 4 commits into from
Jul 22, 2020

Conversation

lydiamross
Copy link
Contributor

@lydiamross lydiamross commented Jun 23, 2020

Which issue does this close?

Closes LLC-234

Breaking Changes for Merge Commit

BREAKING CHANGE: Removes maxScan parameter from API
BREAKING CHANGE: Requires Mongo 4.2

@ryasmi
Copy link
Member

ryasmi commented Jun 23, 2020

Added breaking changes for merge commit to PR description.

Copy link
Member

@ryasmi ryasmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's wait for James to take a look at the index change in the migration before approving.

@ctm8788
Copy link

ctm8788 commented Jul 1, 2020

This change seems like it will prevent any users who deploy to Azure and use CosmosDB mongoAPI from being able to deploy the application. Currently the API is only at 3.6

@ryasmi
Copy link
Member

ryasmi commented Jul 1, 2020

@ctm8788 that is very true, we appreciate your concern, we've never officially supported CosmosDB and always recommend using Mongo.

@ryasmi ryasmi merged commit bec94da into master Jul 22, 2020
@ryasmi ryasmi deleted the LLC-234 branch July 22, 2020 12:12
@HT2Bot
Copy link
Member

HT2Bot commented Jul 22, 2020

🎉 This PR is included in version 7.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants