Update Learnosity SDK to the latest version #89
Conversation
shtrom
force-pushed
the
feature/sdk-composer
branch
2 times, most recently
from
23c4db8
to
d7e402c
Compare
shtrom
force-pushed
the
feature/sdk-composer
branch
from
d7e402c
to
19a9b26
Compare
shtrom
force-pushed
the
feature/sdk-composer
branch
from
19a9b26
to
3ac1417
Compare
|
Notes: still on hold. We cannot run the build step from Jenkins as it only does a remote merge without a local checkout of the code. Learnosity/salt-states#1457 is an alternative proposal, doing the build when the repo is updated. |
|
@shtrom this is not working for me. It looks like composer is changing the location of the autoload.php files so the SDK is failing on init |
|
Actually, it looks like there were some conflicts during merge that are causing issues. Can you please merge develop to this branch and confirm if that's working fine for you? |
This comment has been minimized.
This comment has been minimized.
shtrom
force-pushed
the
feature/sdk-composer
branch
from
3ac1417
to
cb89c91
Compare
|
@gonzalozawa ok, I've rebased onto This PR is now safe to merge, after the usual round of testing of course 😉 |
|
@shtrom thanks for this! |
Signed-off-by: Olivier Mehani <olivier.mehani@learnosity.com>
shtrom
force-pushed
the
feature/sdk-composer
branch
from
cb89c91
to
2d2b257
Compare
|
Ok, I updated the README. I kept a reference to |
This is not great practice for production code, but this makes it easier to get started. Signed-off-by: Olivier Mehani <olivier.mehani@learnosity.com>
shtrom
force-pushed
the
feature/sdk-composer
branch
from
2d2b257
to
e474fb5
Compare
|
@shtrom thanks for that. Looks good to me. I am happy to get this merged now. |
|
Cool. Yes, please do.
…On Fri, 25 Jan 2019 at 01:48, Gonzalo Zawadzki ***@***.***> wrote:
@shtrom <https://github.com/shtrom> thanks for that. Looks good to me. I
am happy to get this merged now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#89 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJyGKfTWDBcPnA3p21F8WY94awxDXiOks5vGcecgaJpZM4VMMNg>
.
|
* [FEATURE] Install Learnosity SDK using composer * [VENDOR] Vendor learnosity-sdk-php and dependencies This is not a great practice for production code, but this makes it easier to get started. Signed-off-by: Olivier Mehani <olivier.mehani@learnosity.com>
This PR updates the SDK to the latest version.
Since v0.8.0, the SDK requires the use of
composerto install it and dependencies, so theMakefilehas been expanded to hide the added step of getting composer up and running with the least amount of fuss.A
./get-composer.shscript is also provided to abstract the steps of downloading a local version.