Run phpstan on code base

Leaseweb · Jul 22, 2018 · 7f519a7 · 7f519a7
1 parent 4a7f869
commit 7f519a7
Show file tree

Hide file tree

Showing 7 changed files with 91 additions and 103 deletions.
diff --git a/composer.lock b/composer.lock
diff --git a/src/Client/SoapClient.php b/src/Client/SoapClient.php
@@ -15,6 +15,7 @@ class SoapClient extends \SoapClient implements LoggerAwareInterface
 
     protected $structs;
     protected $methods;
+    protected $_requestXml;
 
     public function __construct($endpoint, $options = [])
     {
@@ -171,7 +172,7 @@ protected function __parseAllStructs()
         if (true === empty($types)) {
             $this->logger->debug('Found 0 structs in WSDL');
         } else {
-            $this->logger->debug('Found following structs in WSDL: ' . print_r($types, 1));
+            $this->logger->debug('Found following structs in WSDL: ' . print_r($types, true));
         }
 
         foreach ($types as $raw_struct) {
@@ -182,7 +183,7 @@ protected function __parseAllStructs()
                 continue;
             }
 
-            $this->logger->debug('Found struct `' . $struct['name'] . '` with arguments ' .print_r($struct['body'], 1));
+            $this->logger->debug('Found struct `' . $struct['name'] . '` with arguments ' . print_r($struct['body'], true));
 
             $this->structs[$struct['name']] = $struct['body'];
         }

diff --git a/src/Command/CallMethodCommand.php b/src/Command/CallMethodCommand.php
@@ -75,6 +75,6 @@ protected function execute(InputInterface $input, OutputInterface $output)
         $this->logger->debug('Calling method took ' . (microtime(true) - $start_time) . ' seconds');
         unset($start_time);
 
-        $output->writeln(print_r($response, true));
+        $output->writeln((string) print_r($response, true));
     }
 }
diff --git a/src/Command/ListMethodsCommand.php b/src/Command/ListMethodsCommand.php
@@ -26,7 +26,7 @@ protected function configure()
     protected function execute(InputInterface $input, OutputInterface $output)
     {
         foreach (array_keys($this->soapClient->__getMethods()) as $method) {
-            $output->writeln($method);
+            $output->writeln((string) $method);
         }
     }
 }
diff --git a/src/File/TmpFile.php b/src/File/TmpFile.php
@@ -12,7 +12,7 @@ public function __construct()
     {
         $tmpfile = tmpfile();
 
-        if (false === $tmpfile) {
+        if (!is_resource($tmpfile)) {
             throw new \RuntimeException('Unable to create a tmp file');
         }
 

diff --git a/src/Helper/StdinHelper.php b/src/Helper/StdinHelper.php
@@ -13,7 +13,7 @@ public function read($blocking = null)
         }
 
         if (false === is_null($blocking)) {
-            stream_set_blocking($stream, (bool) $blocking ? 1 : 0);
+            stream_set_blocking($stream, (bool) $blocking);
         }
 
         $buffer = null;

diff --git a/src/Listener/CommandEventListener.php b/src/Listener/CommandEventListener.php
@@ -34,17 +34,4 @@ public function onCommandAction(ConsoleCommandEvent $event)
 
         $command->setSoapClient($this->container->get('soap_client'));
     }
-
-    // protected function getEndpoint(InputInterface $input)
-    // {
-    //     $endpoint = $input->getOption('endpoint');
-
-    //     if (false === is_null($endpoint)) {
-    //         return $endpoint;
-    //     } elseif (true === array_key_exists('SOAPCLIENT_ENDPOINT', $_SERVER)) {
-    //         return $_SERVER['SOAPCLIENT_ENDPOINT'];
-    //     } else {
-    //         throw new \InvalidArgumentException('You must specify an endpoint.');
-    //     }
-    // }
 }