feat: change profile picture to drive off filename vs personId #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: profile-picture personId property has been removed. Use fileName to supply profile picture file name off the CDN. link-to-profile was replaced by profile-picture-link-person-id where a person id must be supplied to construct a valid like to directory. All cache busting was removed because it is no longer needed with this approach. A profilePictureFileName was added to user manager to supply picture file name of logged in user.
aarondrabeck
force-pushed
the
profile-picture
branch
from
4ab9e10
to
1b85c82
Compare
kaseyhinton
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: profile-picture personId property has been removed. Use fileName to supply profile picture file name off the CDN. link-to-profile was replaced by profile-picture-link-person-id where a person id must be supplied to construct a valid link to directory. All cache busting was removed because it is no longer needed with this approach. A profilePictureFileName was added to user manager to supply picture file name of logged in user.