Missions/buttons

[Bondok6]

Hello @Leboroz 🙋‍♂️,

Thanks for taking the time to review my project.

---

I've done with these issues

• [3pt] Implement mission joining - Actions #10
• [1pt] Implement mission leaving - Actions #9
• [1pt] Switch badges for Missions - Conditional components #6

[Leboroz]

Hello @Bondok6, 👋

Good job so far. I learned a lot with this code.

[Leboroz]

I think it is more efficient to do a variable(But I am not sure we could argue):

const button = !status 
  ? { class: "secondary", text: "Not a Member" } 
  : { class: "secondary", text: "Active Member" };

.
.
.

<Badge bg={button.class}>{button.text}</Badge>

[Bondok6]

Thank you for your review @Leboroz, but In my opinion it's not a big deal because React doc uses the same way (Inline If-Else with Conditional Operator)

Maybe your way is more readable but I can use it only with the badges. But I can't use it with the buttons because I have events on these buttons (onClick).

I agree that your way is more readable, so I will implement it on the badges. 💯