Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved onPaint performance #48

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

eliopark-nsuslab
Copy link

  • Use dirtyRects instead of the whole image when onPaint()
  • Use concurrency::parallel_for to take advantage of multiple cores

- Use dirtyRects instead of the whole image when onPaint()
- Use concurrency::parallel_for to take advantage of multiple cores
@eliopark-nsuslab
Copy link
Author

I used <ppl.h> but I don't know if it's available on Linux, the github build passed.
I only tested it on windows.

@Lecrapouille
Copy link
Owner

@eliopark-nsuslab thanks again, I was busy ! I'll test it on Linux tonight :)

@Lecrapouille
Copy link
Owner

@eliopark-nsuslab Concerning ppl.h I do not have it on my Debian they offer ppl.hh :( I dunno why it compiles on my CI (ubuntu). Why not using openmp ?

@Lecrapouille Lecrapouille merged commit f67adba into Lecrapouille:godot-4.x Mar 25, 2024
2 checks passed
@Lecrapouille
Copy link
Owner

Lecrapouille commented Mar 25, 2024

@eliopark-nsuslab hummmm when merging your commit the Linux CI finally failed lol :) I tried with OpenMP. In the build.py I added a setting (while it would have been better to check if openmp is present). I will check if it passes CI. If you are interested on an interesting problem is to try to understand why the project a friend of mine made is slow with my CEF and keyboard broken https://www.exaequos.com/ (while the secondary process works well)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants