Merge pull request #593 from LedFx/harden_invalid_config_handling

Catch invalid schemas in Effect class
LedFx · Jan 7, 2024 · 5c200a2 · 5c200a2
2 parents 941dffe + 0898abd
commit 5c200a2
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/ledfx/effects/__init__.py b/ledfx/effects/__init__.py
@@ -293,7 +293,13 @@ def deactivate(self):
 
     def update_config(self, config):
         self.lock.acquire()
-        validated_config = type(self).schema()(config)
+        try:
+            validated_config = type(self).schema()(config)
+        except vol.Invalid as err:
+            _LOGGER.warning(f"Error updating effect {self.NAME} config: {err}")
+            self.lock.release()
+            return
+
         prior_config = self._config
 
         if self._config != {}: