Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid segment pixels:: Protect virtuals segments from devices pixels count change #799

Closed
bigredfrog opened this issue Feb 24, 2024 · 1 comment

Comments

@bigredfrog
Copy link
Contributor

Quoting from discord thread https://discord.com/channels/469985374052286474/1210772751800074240/1210772837443440711

I noticed in the dev builds my own system generated such an error into sentry

Invalid segment pixels: (0, 91). Device 'breakme' valid pixels between (0, 57)
However, looking at the setup, the actual issue is that I have

Invalid segment pixels (0, 91) against virtual 'breakme' where the segment is mapped against device 'fake128' that is set to 58 pixels (0, 57)

This is the scenerio where device has its pixel count reduced, we don't yet proliferate that reduction in pixels into all the virtuals that reference it as a segment.

@bigredfrog
Copy link
Contributor Author

PR merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant