⚠️⚠️⚠️ Breaking: Update Presets/Virtuals API ⚠️⚠️⚠️ #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am bad at git. I didn't merge this, magic just happened when I resynced. Oops. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the last instances of
default_presetsandcustom_presetsthat are leftover from a long time ago.This breaks the frontend and any other clients using the HTTP API, but should simplify things moving forward (not having to remap from old name to new name forever etc)
This doesn't actually fix the bug that I was looking at/for discord thread - that's caused by the frontend incorrectly sending default_presets as the category for user presets.
I've had a look at the frontend and have made a PR but I don't know enough to fix all of the problems.