Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch invalid schemas in Effect class #593

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Catch invalid schemas in Effect class #593

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ledfx/effects/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,13 @@ def deactivate(self):

def update_config(self, config):
self.lock.acquire()
validated_config = type(self).schema()(config)
try:
validated_config = type(self).schema()(config)
except vol.Invalid as err:
_LOGGER.warning(f"Error updating effect {self.NAME} config: {err}")
self.lock.release()
return

prior_config = self._config

if self._config != {}:
Expand Down