Fix glitch on gif first frame resize

[bigredfrog]

First extracted frame from a GIF is always coming in as P

following frames are defaulted to RGB

Pillow will only use nearest on P for resize

Force ALL frames to RGB on extraction

Now resize method will be obeyed

Tested glitch is gone on gif that was easy to see impact
Tested all other presets still work

Summary by CodeRabbit

• Bug Fixes
  • Improved the handling of frame data in the Keybeat2D effect to ensure proper configuration updates.

[coderabbitai]

Warning

Rate Limit Exceeded

@bigredfrog has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 39 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 08a0b0a and 5f349cd.

Walkthrough

The keybeat2d.py file within the LedFx effects module has been updated to enhance the way frames are stored. Previously, frames were copied directly to self.orig_frames. Now, each frame undergoes a conversion process before being appended to self.orig_frames, indicating a possible change in the frame data structure or the addition of a new processing step to the frames before storage.

Changes

File Path	Change Summary
.../effects/keybeat2d.py	Updated config_updated function to append a converted copy of frames to self.orig_frames instead of a direct copy.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 63d71ee and 08a0b0a.

Files selected for processing (1)

• ledfx/effects/keybeat2d.py (1 hunks)

Additional comments: 1

ledfx/effects/keybeat2d.py (1)

• 149-149: The conversion of frames to 'RGB' mode is implemented as intended to address the inconsistency in resizing the first frame of a GIF.