-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable console for non-prod CI builds #737
Conversation
WalkthroughThe updates involve enhancing the integration with Sentry for better error tracking and release management, refining the import list to focus more on Sentry SDK integrations, and adjusting the packaged binaries' behavior for both OSX and Windows platforms. These changes aim to improve the development workflow, error reporting, and user experience by dynamically setting environment variables and controlling console visibility based on the build context. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (4)
- .github/workflows/test-build-binaries.yml (1 hunks)
- hiddenimports.py (2 hunks)
- osx-binary.spec (2 hunks)
- windows-binary.spec (2 hunks)
Additional comments: 4
hiddenimports.py (1)
- 32-39: Ensure the added Sentry SDK imports are utilized within the project to enhance error reporting as intended.
windows-binary.spec (1)
- 10-19: The conditional logic for setting
SHOW_CONSOLE
based on the build type is correctly implemented. Ensure this behavior is consistent across all platforms.osx-binary.spec (1)
- 11-20: The implementation of
prod.env
creation and conditionalSHOW_CONSOLE
setting aligns with the PR objectives. Ensure consistency in handling across different platforms..github/workflows/test-build-binaries.yml (1)
- 540-558: The steps for downloading LedFx version information and updating the Sentry configuration are correctly implemented. Verify these changes effectively integrate with the Sentry error reporting mechanism.
Removes a lot of redundant/old/not needed/working hidden imports.
We check to see if the CI is associated with a release tag - if it is, turn console off.
If it isn't, enable console.
Should provide a bit more info/ability to see what issues are if we need to direct people to the CI artifacts.
Also updates the sentry CI to... work.
Summary by CodeRabbit