Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable console for non-prod CI builds #737

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

shauneccles
Copy link
Member

@shauneccles shauneccles commented Feb 12, 2024

Removes a lot of redundant/old/not needed/working hidden imports.

We check to see if the CI is associated with a release tag - if it is, turn console off.
If it isn't, enable console.

Should provide a bit more info/ability to see what issues are if we need to direct people to the CI artifacts.

Also updates the sentry CI to... work.

Summary by CodeRabbit

  • Chores
    • Updated steps in CI for creating Sentry releases with LedFx version information.
  • Refactor
    • Adjusted import statements to enhance error tracking and remove unused libraries.
  • New Features
    • Introduced environment control for packaged binaries, including release identification and console visibility settings for both OSX and Windows platforms.

Copy link
Contributor

coderabbitai bot commented Feb 12, 2024

Walkthrough

The updates involve enhancing the integration with Sentry for better error tracking and release management, refining the import list to focus more on Sentry SDK integrations, and adjusting the packaged binaries' behavior for both OSX and Windows platforms. These changes aim to improve the development workflow, error reporting, and user experience by dynamically setting environment variables and controlling console visibility based on the build context.

Changes

File(s) Summary
.github/workflows/test-build-binaries.yml Added steps for downloading LedFx version info and updating Sentry release details; updated Sentry org name.
hiddenimports.py Refined imports by removing some and adding Sentry SDK integrations.
osx-binary.spec, windows-binary.spec Introduced prod.env creation, dynamic IS_RELEASE setting, and conditional SHOW_CONSOLE visibility.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 42ae655 and 37fa578.
Files selected for processing (4)
  • .github/workflows/test-build-binaries.yml (1 hunks)
  • hiddenimports.py (2 hunks)
  • osx-binary.spec (2 hunks)
  • windows-binary.spec (2 hunks)
Additional comments: 4
hiddenimports.py (1)
  • 32-39: Ensure the added Sentry SDK imports are utilized within the project to enhance error reporting as intended.
windows-binary.spec (1)
  • 10-19: The conditional logic for setting SHOW_CONSOLE based on the build type is correctly implemented. Ensure this behavior is consistent across all platforms.
osx-binary.spec (1)
  • 11-20: The implementation of prod.env creation and conditional SHOW_CONSOLE setting aligns with the PR objectives. Ensure consistency in handling across different platforms.
.github/workflows/test-build-binaries.yml (1)
  • 540-558: The steps for downloading LedFx version information and updating the Sentry configuration are correctly implemented. Verify these changes effectively integrate with the Sentry error reporting mechanism.

@shauneccles shauneccles merged commit 34351d4 into LedFx:main Feb 12, 2024
16 of 17 checks passed
@shauneccles shauneccles deleted the fix/debug_ci_builds branch February 12, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant