-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning about sounddevice in main.py #910
Conversation
WalkthroughThe recent update introduces a visually distinct ASCII art warning message in the Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional comments not posted (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Actionable comments outside the diff hunks (1)
ledfx/__main__.py (1)
Line range hint
267-268
: Consider adding a comment to clarify that the division by zero is intentional for testing purposes. This will help maintain clarity for future maintainers.+ # Intentionally causing a crash to test the Sentry crash logger div_by_zero = 1 / 0
This pull request adds a warning message in the main.py file to inform developers not to use sounddevice within the file - noting that this should include importing any classes that use/call sounddevice as well.
This is to prevent potential issues and conflicts with pystrays user of threading.
See
#908
https://discord.com/channels/469985374052286474/1226981278449143829
https://discord.com/channels/469985374052286474/1226711270489718915
Summary by CodeRabbit