-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compare generated addresses with the expected ones in the client library #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #166 +/- ##
========================================
Coverage 83.96% 83.96%
========================================
Files 17 17
Lines 2189 2189
========================================
Hits 1838 1838
Misses 351 351
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bigspider
force-pushed
the
client-check-address
branch
4 times, most recently
from
May 30, 2023 11:06
ff349f1
to
f944e7a
Compare
bigspider
force-pushed
the
client-check-address
branch
from
June 13, 2023 13:54
f944e7a
to
778ffa8
Compare
bigspider
force-pushed
the
client-check-address
branch
from
June 14, 2023 08:08
79183c3
to
dbd5723
Compare
sgliner-ledger
previously approved these changes
Jun 19, 2023
bigspider
force-pushed
the
client-check-address
branch
from
June 19, 2023 08:24
dbd5723
to
375277b
Compare
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #141 with a more generic solution: derive addresses from the wallet policy on the client side, and fail if they differ.
The libraries used for client side are generation are externally developed.
paranoid_client
feature is kept as an optional feature, but enabled by default.For JavaScript, there doesn't seem to be a viable library for descriptors. bitcoinerlab/miniscript is currently the only one, which wraps the WASM-compiled version of https://github.com/sipa/miniscript which unfortunately doesn't directly export the miniscript => Script compilation. Therefore, the JS library is still explicitly blacklisting app versions with known bugs, rather than using the generic approach above.