Add support for musig() key expressions #230
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigspider
force-pushed
the
musig
branch
4 times, most recently
from
ef7dd97
to
420aa97
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #230 +/- ##
===========================================
- Coverage 84.89% 84.80% -0.10%
===========================================
Files 17 17
Lines 2205 2250 +45
===========================================
+ Hits 1872 1908 +36
- Misses 333 342 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bigspider
force-pushed
the
musig
branch
2 times, most recently
from
23b3795
to
4ca8540
Compare
bigspider
force-pushed
the
musig
branch
2 times, most recently
from
a49892d
to
3be0d39
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+450
to
+475
| // int pk_offset = is_tap ? 1 : 0; | ||
| // if (memcmp(pubkey.compressed_pubkey + pk_offset, bip32_derivation_pubkey, key_len) != 0) | ||
| // { | ||
| // return 0; | ||
| // } |
Check notice
Code scanning / CodeQL
Commented-out code Note
bigspider
force-pushed
the
musig
branch
3 times, most recently
from
9089b94
to
edb801c
Compare
bigspider
force-pushed
the
musig
branch
4 times, most recently
from
29c6f57
to
63415a1
Compare
bigspider
force-pushed
the
musig
branch
3 times, most recently
from
612f6d6
to
a6927b0
Compare
…icies to more general key expressions
…ed some comments. Generalizing to key expressions containing musig() makes it necessary to distinguish the key expressions in the wallet policy from the actual key placeholders that are just indexes to the list of key informations (@num in the descriptor template), whereas the two concepts were often not clearly separated in the code base. Renaming to "key expressions" makes the distinction more clear.
…on type is used; generalized some parts of the code that are not generalized to musig key expressions, and annotated some others.
…ues in sign_psbt in the python client
- musig() now sorts the keys, as per the BIP draft - correctly compute fingerprint for musig() aggregate key - added both the aggregate and the internal key in keyexpr_info_t struct - fixed psbt parsing logic to detect change/addr_index for musig - updated musig tests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #208