Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textual mode + EVM #21

Closed
wants to merge 63 commits into from

Merge pull request #93 from cosmos/restriction_evm

99df548
Select commit
Loading
Failed to load commit list.
Closed

Textual mode + EVM #21

Merge pull request #93 from cosmos/restriction_evm
99df548
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Jun 13, 2023 in 4s

7 new alerts

New alerts in code changed by this pull request

  • 7 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 235 in deps/tinycbor/src/cbor.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable CborIndefiniteLength is never read.

Check notice on line 624 in deps/tinycbor-ledger/cborvalidation.c

See this annotation in the file changed.

Code scanning / CodeQL

Long switch case Note

Switch has at least one case that is too long:
CborTextStringType (32 lines)
.

Check notice on line 422 in deps/tinycbor-ledger/cborvalidation.c

See this annotation in the file changed.

Code scanning / CodeQL

Equality test on floating-point values Note

Equality checks on floating point values can yield unexpected results.

Check notice on line 428 in deps/tinycbor-ledger/cborvalidation.c

See this annotation in the file changed.

Code scanning / CodeQL

Equality test on floating-point values Note

Equality checks on floating point values can yield unexpected results.

Check notice on line 339 in deps/tinycbor-ledger/cborvalidation.c

See this annotation in the file changed.

Code scanning / CodeQL

For loop variable changed in body Note

Loop counters should not be modified in the body of the
loop
.

Check notice on line 152 in deps/tinycbor/src/cbor.h

See this annotation in the file changed.

Code scanning / CodeQL

Irregular enum initialization Note

In an enumerator list, the = construct should not be used to explicitly initialize members other than the first, unless all items are explicitly initialized.

Check notice on line 126 in deps/tinycbor/src/cbor.h

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.