Oxen test fixes and improvements #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid a compiler warning about the fall-through.
This lets the device be forcibly reset to a specific network type by the companion software wallet. This command is *only* permitted when the wallet is compiled in debug mode. This also allows putting the wallet into fakechain mode, which is needed for network tests, and allows doing so without needing (or exposing) a fakechain setting.
Fixes various Ledger display messages that confusing reference LNS instead of ONS. This also changes all the constants along the way (to make it consistent with the Oxen core code, which renamed them as such a long time ago).
|
Hello @jagerman , Also you might be interested in the test framework we developed, it's a pytest based framework that handles the Speculos, automatic screen navigation, screenshot comparison, etc |
0x200 hurts nothing on non-X, and 0x40 should be there on X for being able to request PIN verification. (This also matches the flags used, now, in the Monero app and various other official apps).
This was necessary in older Nano S SDK, but apparently isn't needed anymore.
|
Hi @jagerman can you please add the |
|
cc @darcys22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supercedes #16 and adds other some other small changes and capabilities to go with the high-level Oxen wallet ledger test suite (oxen-io/oxen-core#1640).