Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Xmacro to centralize selectors definition #100

Closed
wants to merge 1 commit into from
Closed

Use Xmacro to centralize selectors definition #100

wants to merge 1 commit into from

Conversation

fbeutin-ledger
Copy link
Contributor

Pros:

  • 3 less EDIT THIS
  • No risk of mismatch between enum order and array order
  • No risk of badly defining the NUMBER

Con:

  • might be a bit less explicit ?

@fbeutin-ledger fbeutin-ledger force-pushed the fbe/improvements_before_uniswap_dev branch 4 times, most recently from 9469f5f to 84b08fc Compare October 23, 2023 12:02
tdejoigny-ledger
tdejoigny-ledger reviewed Oct 23, 2023
View reviewed changes
src/boilerplate_plugin.h Outdated Show resolved Hide resolved
src/xmacro_helpers.h Show resolved Hide resolved
@fbeutin-ledger fbeutin-ledger force-pushed the fbe/improvements_before_uniswap_dev branch from 84b08fc to 733dbd6 Compare October 23, 2023 14:04
@fbeutin-ledger
Copy link
Contributor Author

#103

@fbeutin-ledger fbeutin-ledger deleted the fbe/improvements_before_uniswap_dev branch October 26, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdejoigny-ledger tdejoigny-ledger tdejoigny-ledger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fbeutin-ledger @tdejoigny-ledger