Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial boilerplate to setup Go project #1

Merged
merged 1 commit into from Jul 13, 2020
Merged

Initial boilerplate to setup Go project #1

merged 1 commit into from Jul 13, 2020

Conversation

onyb
Copy link
Contributor

@onyb onyb commented Jul 10, 2020

Introduces the following components:

  • magefile: run developer actions using the mage tool.
  • version: package exporting project version, and build-time values such as commit-hash, architecture target, OS target, and build date.
  • log: package exposing public wrappers around logrus functions.
  • config: package to read configuration using viper.

@onyb
Initial boilerplate for Go project
044e011 
Introduces the following components:
  * magefile: run developer actions using the mage tool.

  * version: package exporting project version, and build-time values
    such as commit-hash, architecture target, OS target, and build
    date.

  * log: package exposing public wrappers around logrus functions.

  * config: package to read configuration using viper.
@onyb onyb requested a review from noirbizarre July 10, 2020 12:03
@onyb onyb self-assigned this Jul 10, 2020
vbergeron-ledger
vbergeron-ledger approved these changes Jul 13, 2020
View reviewed changes
Copy link

@vbergeron-ledger vbergeron-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand why the boilerplate for config / logging is not yet handled by a proper library but I trust you. Let's :go: 🎉

config/config.go Show resolved Hide resolved
@onyb onyb merged commit fb32844 into LedgerHQ:master Jul 13, 2020
@onyb onyb deleted the init branch July 13, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbergeron-ledger vbergeron-ledger vbergeron-ledger approved these changes

@noirbizarre noirbizarre Awaiting requested review from noirbizarre

Assignees

@onyb onyb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@onyb @vbergeron-ledger