Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

Improve Identifier display in firmware update #1576

Closed
dasilvarosa opened this issue Oct 11, 2018 · 3 comments
Closed

Improve Identifier display in firmware update #1576

dasilvarosa opened this issue Oct 11, 2018 · 3 comments
Labels
enhancement this is a polish / an improvement of the existing state of the app good first issue this is an easy to fix task. typically something the community can take.

Comments

@dasilvarosa
Copy link
Contributor

During a firmware update the Identifier is shown on the device and should be verified on the Manager.

  • Ledger Nano S and Ledger Blue only show the first 4 and last 4 characters of the Identifier: [ABCD...1234].

  • Ledger Live shows the entire string. This should be reduced to match the characters displayed on the device.
@gre
Copy link
Contributor

gre commented Oct 11, 2018

easy to fix. hard to test.

@gre gre added good first issue this is an easy to fix task. typically something the community can take. enhancement this is a polish / an improvement of the existing state of the app labels Oct 11, 2018
juan-cortes added a commit to juan-cortes/ledger-live-desktop that referenced this issue Oct 12, 2018
@juan-cortes
Addreses the inconsistency between firmware versions displayed
7473201 
LedgerHQ#1576
@juan-cortes juan-cortes mentioned this issue Oct 12, 2018
Merged
@juan-cortes
Copy link
Contributor

This is done

@gre
Copy link
Contributor

gre commented Oct 16, 2018

Thanks a lot

@gre gre closed this as completed Oct 16, 2018
@meriadec meriadec mentioned this issue Oct 17, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement this is a polish / an improvement of the existing state of the app good first issue this is an easy to fix task. typically something the community can take.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gre @dasilvarosa @juan-cortes