This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
Ripple: handle case the destination does not exist #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meriadec
previously approved these changes
Sep 26, 2018
| @@ -1 +1,2 @@ | |||
| package.json | |||
| test-e2e/**/*.json | |||
gre
commented
Sep 26, 2018
static/i18n/en/errors.json
Outdated
| @@ -99,6 +99,9 @@ | |||
| "title": "Oops, insufficient balance", | |||
| "description": "Make sure the account to debit has sufficient balance" | |||
| }, | |||
| "NotEnoughBalanceBecauseDestinationNotCreated": { | |||
| "title": "Destination does not exist. Send at least {{minimalAmount}}" | |||
There was a problem hiding this comment.
@dasilvarosa can you think of a better wording or it is ok?
dasilvarosa
suggested changes
Sep 26, 2018
static/i18n/en/errors.json
Outdated
| @@ -99,6 +99,9 @@ | |||
| "title": "Oops, insufficient balance", | |||
| "description": "Make sure the account to debit has sufficient balance" | |||
| }, | |||
| "NotEnoughBalanceBecauseDestinationNotCreated": { | |||
| "title": "Destination does not exist. Send at least {{minimalAmount}}" | |||
There was a problem hiding this comment.
"Recipient address is inactive. Send at least {{minimalAmount}} to activate it"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error if trying to send XRP to a non existing accounts and if not enough funds to create it.
Type
improvement
Context
LIVE-252
Parts of the app affected / Test plan
ripple / send