Max account decimals before trim and tooltip for whole value

[jorge-cob]

Type

Bug Fix, UI Polish...

Context

Account's balance was overflowing the wrapper where there are lot of decimal values in a small screen

Parts of the app affected / Test plan

[gre]

neat!

[gre]

should the unit check be done in the if? because as far as i read it, if there is no unit, we would have no tooltip right?

if (showTooltip && unit) {
    return <Tooltip render={() => formatCurrencyUnit(unit, val)}> {content} </Tooltip>
}

I imagine this case never present, but code is easier to understand

[gre]

good

[Arnaud97234]

Bug found
Account balance should be responsive. By resizing the window, account pane become large enough to display all the balance digits.

How to reproduce

• Import app.json file (enclosed)
• On portfolio screen, resize app window.

app.json.txt

[gre]

Ok so base on this feedback and fact the window can resize & need to be somewhat responsive, i'm going to suggest a different implementation:

• For the actual ... rendering, I would prefer we use classical CSS ellipsis https://developer.mozilla.org/en-US/docs/Web/CSS/text-overflow . That's the only true way we can make it correct, because (1) the font is not monospace (2) it have different sizes on different OSs (3) you can resize the window so the width possibilities is infinite.
• For dynamic presence of the Tooltip, this is getty a bit harder to implement it right I feel. We would need a way to know if the CSS ellipsis is on or not, and you probably need to check for that at each window resize or even re-rendering.. we will have to be very careful about performance of this / tradeoff can be found. I would be ok having a first implementation that always show the tooltip as a first step (even tho i think it's better to not show it always)

[gre]

I think it was fixed in Accounts rework