rework UI for coin control

[valpinkman]

Type

UI Improvement

Context

LL-1684

Parts of the app affected / Test plan

Coin Control

[github-actions]

PR to merge feat/coin-control 54ff8d6 -> develop

Diff output

Please download attached snapshots.zip, extract it in folder and update your PR with it

[dasilvarosa]

Awesome work! Some minor remarks:

Send step 2 (Amount)

• Change order of the toggles: RBF first.
• RBF enabled by default.
• Reword (add a comma): “Include coins from unconfirmed, replaceable transactions”
• Reword: "Allow speeding up the transaction later by increasing the network fees (Replace-By-Fee)"
• Add infobubble on "Coin control" CTA hover: "You must first enter an amount." Figma

Select coins modal

• Reword title: Select coins --> Coin control
• DOGE 10 —> 10 DOGE to be consistent with the new way of displaying units
• More spacing between CTA and support link
• Reword strategies: “Oldest coins first (FIFO)“, “Minimize fees (optimize size)“, “Minimize future fees (merge coins)”
• Slight reword: "You cannot select coins from unconfirmed, replaceable transactions."
• Implement not enough coins selected error case like in the design. Make sure it's stickied when scrolling down the list of inputs. Also make sure the "Coins to spend" / "Change to return" do not disappear and display a "-" like in the design. Figma
• Reword: "INPUT 0" --> "SELECTED" (more intuitive UX)

[valpinkman]

Implement not enough coins selected error case like in the design. Make sure it's stickied when scrolling down the list of inputs.
@dasilvarosa seen with Chris, we keep the same banner for now, as there will be a new task to update them.

• sticky done

I believe if we want a new error text, we need to throw a new error type (this involves libcore I think)

[Arnaud97234]

Bugs found

1. In the coin control modal -> Pending tx: "Pending" and "Replaceable" text should be in Red.

Actual

Expected

---

---

2. UTXOs shouldn't be displayed twice

___________ ___________

3. Maximum spendable should adapt when user turns OFF "Include coin from unconfirmed / replaceable tx" AND there are some UTXOs corresponding to RBF tx.

• if OFF -> Max spendable = Balance - Replaceable UTXOs

[Arnaud97234]

In the coin control modal -> Pending tx: "Pending" and "Replaceable" text should be in Red.

Actual

Expected