Skip to content

Commit

Permalink
fix(lld): fix analytics problem
Browse files Browse the repository at this point in the history
  • Loading branch information
LucasWerey committed May 6, 2024
1 parent 8224d69 commit 9ce66ff
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 4 deletions.
5 changes: 5 additions & 0 deletions .changeset/fifty-crews-peel.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"ledger-live-desktop": patch
---

Fix an error that made all analytics disabled on LLD
17 changes: 15 additions & 2 deletions apps/ledger-live-desktop/src/renderer/Default.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React, { useEffect, lazy, Suspense } from "react";
import styled from "styled-components";
import { ipcRenderer } from "electron";
import { Redirect, Route, Switch, useHistory, useLocation } from "react-router-dom";
import { useSelector } from "react-redux";
import { useDispatch, useSelector } from "react-redux";
import TrackAppStart from "~/renderer/components/TrackAppStart";
import { LiveApp } from "~/renderer/screens/platform";
import { BridgeSyncProvider } from "~/renderer/bridge/BridgeSyncContext";
Expand Down Expand Up @@ -48,7 +48,11 @@ import { Flex, InfiniteLoader } from "@ledgerhq/react-ui";
import useAccountsWithFundsListener from "@ledgerhq/live-common/hooks/useAccountsWithFundsListener";
import { accountsSelector } from "./reducers/accounts";
import { useRecoverRestoreOnboarding } from "~/renderer/hooks/useRecoverRestoreOnboarding";
import { hasCompletedOnboardingSelector } from "~/renderer/reducers/settings";
import {
hasCompletedOnboardingSelector,
hasSeenAnalyticsOptInPromptSelector,
} from "~/renderer/reducers/settings";
import { setShareAnalytics, setSharePersonalizedRecommendations } from "./actions/settings";

const PlatformCatalog = lazy(() => import("~/renderer/screens/platform"));
const Dashboard = lazy(() => import("~/renderer/screens/dashboard"));
Expand Down Expand Up @@ -192,6 +196,15 @@ export default function Default() {
useRecoverRestoreOnboarding();

const listAppsV2 = useFeature("listAppsV2minor1");
const analyticsFF = useFeature("lldAnalyticsOptInPrompt");
const hasSeenAnalyticsOptInPrompt = useSelector(hasSeenAnalyticsOptInPromptSelector);
const dispatch = useDispatch();

useEffect(() => {
if (!analyticsFF?.enabled || hasSeenAnalyticsOptInPrompt) return;
dispatch(setShareAnalytics(false));
dispatch(setSharePersonalizedRecommendations(false));
});

useEffect(() => {
if (!listAppsV2) return;
Expand Down
4 changes: 2 additions & 2 deletions apps/ledger-live-desktop/src/renderer/reducers/settings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,8 @@ const INITIAL_STATE: SettingsState = {
pairExchanges: {},
developerMode: !!process.env.__DEV__,
loaded: false,
shareAnalytics: false,
sharePersonalizedRecommandations: false,
shareAnalytics: true,
sharePersonalizedRecommandations: true,
hasSeenAnalyticsOptInPrompt: false,
sentryLogs: true,
lastUsedVersion: __APP_VERSION__,
Expand Down

0 comments on commit 9ce66ff

Please sign in to comment.