fix: nav straight to close modal if no isFromPostOnboardingEntryPoint…

… boolean

.changeset/short-shirts-draw.md

@@ -0,0 +1,5 @@
+---
+"ledger-live-desktop": patch
+---
+
+Add isFromPostOnboardingEntryPoint param to open modal data. Use this to disable the Grow Your ETH staking modal advert when the user first receives ETH during the Stax onboarding flow.

apps/ledger-live-desktop/src/renderer/modals/Receive/Body.tsx

@@ -29,7 +29,7 @@ export type Data = {
   receiveTokenMode?: boolean;
   receiveNFTMode?: boolean;
   eventType?: string;
-  isFromPostOnboardingEntryPoint: boolean;
+  isFromPostOnboardingEntryPoint?: boolean;
 };
 
 type OwnProps = {
@@ -69,6 +69,7 @@ export type StepProps = {
   onChangeAddressVerified: (b?: boolean | null, a?: Error | null) => void;
   onClose: () => void;
   currencyName: string | undefined | null;
+  isFromPostOnboardingEntryPoint?: boolean;
 };
 export type St = Step<StepId, StepProps>;
 const createSteps = (): Array<St> => [
@@ -161,6 +162,7 @@ const Body = ({
     }
     onChangeStepId("receive");
   }, [onChangeAddressVerified, setDisabledSteps, steps, onChangeStepId]);
+
   useEffect(() => {
     const stepId =
       params && params.startWithWarning ? "warning" : params.receiveTokenMode ? "account" : null;
@@ -220,6 +222,7 @@ const Body = ({
     onStepChange: handleStepChange,
     onClose: handleCloseModal,
     currencyName,
+    isFromPostOnboardingEntryPoint: params.isFromPostOnboardingEntryPoint,
   };
   return (
     <Stepper {...stepperProps}>

apps/ledger-live-desktop/src/renderer/modals/Receive/steps/StepReceiveFunds.tsx

@@ -212,7 +212,13 @@ const StepReceiveFunds = (props: StepProps) => {
   const onFinishReceiveFlow = useCallback(() => {
     const dismissModal =
       global.localStorage.getItem(`${LOCAL_STORAGE_KEY_PREFIX}${receivedCurrencyId}`) === "true";
-    if (!dismissModal && !receiveNFTMode && !receiveTokenMode && isStakingEnabledForAccount) {
+    if (
+      !dismissModal &&
+      !receiveNFTMode &&
+      !receiveTokenMode &&
+      isStakingEnabledForAccount &&
+      !isFromPostOnboardingEntryPoint
+    ) {
       track("button_clicked2", {
         button: "continue",
         page: window.location.hash
@@ -223,8 +229,8 @@ const StepReceiveFunds = (props: StepProps) => {
         modal: "receive",
         account: name,
       });
-      // Only open EVM staking modal if the user received ETH or an EVM currency supported by the providers, and the user is not in the post-onboarding flow.
-      if (isDirectStakingEnabledForAccount && !isFromPostOnboardingEntryPoint) {
+      // Only open EVM staking modal if the user received ETH or an EVM currency supported by the providers
+      if (isDirectStakingEnabledForAccount) {
         dispatch(
           openModal("MODAL_EVM_STAKE", {
             account: mainAccount,