bugfix(PROTECT-3040): ensure recover webview does not reload on devic…

…e disconnect
LedgerHQ · May 2, 2024 · d4b897f · d4b897f
1 parent 3498ae5
commit d4b897f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/.changeset/angry-garlics-try.md b/.changeset/angry-garlics-try.md
@@ -0,0 +1,5 @@
+---
+"ledger-live-desktop": patch
+---
+
+Ensure user remains on Recover without reload given device is disconnected
diff --git a/apps/ledger-live-desktop/src/renderer/screens/recover/Player.tsx b/apps/ledger-live-desktop/src/renderer/screens/recover/Player.tsx
@@ -85,16 +85,13 @@ export default function RecoverPlayer({
       ...params,
       ...queryParams,
     }),
-    [
-      theme,
-      locale,
-      availableOnDesktop,
-      device?.modelId,
-      state?.deviceId,
-      currency,
-      params,
-      queryParams,
-    ],
+    /**
+     * deviceModelId is purposely ignored from dependencies.
+     *
+     * This is to ensure the WebRecoverPlayer is not reloaded given the user disconnects their cable.
+     */
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+    [theme, locale, availableOnDesktop, state?.deviceId, currency, params, queryParams],
   );
 
   return manifest ? (