Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix: playwright CI #1864

Closed
wants to merge 7 commits into from
Closed

WIP: Fix: playwright CI #1864

wants to merge 7 commits into from

Conversation

alexandremgo
Copy link
Contributor

πŸ“ Description

For now: just to trigger fully the CI. This PR is WIP

❓ Context

  • Impacted projects: LLD
  • Linked resource(s): ``

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Nov 18, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Nov 18, 2022 at 3:27PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 18, 2022 at 3:27PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Nov 18, 2022 at 3:27PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Nov 18, 2022 at 3:27PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2022

⚠️ No Changeset found

Latest commit: 485fbe9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the desktop Has changes in LLD label Nov 18, 2022
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 84.62% // Head: 44.90% // Decreases project coverage by -39.71% ⚠️

Coverage data is based on head (485fbe9) compared to base (b926507).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1864       +/-   ##
============================================
- Coverage    84.62%   44.90%   -39.72%     
============================================
  Files           21      663      +642     
  Lines         1463    28563    +27100     
  Branches       271     7667     +7396     
============================================
+ Hits          1238    12826    +11588     
- Misses         218    15683    +15465     
- Partials         7       54       +47     
Flag Coverage Ξ”
test 44.90% <ΓΈ> (-39.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
libs/ledgerjs/packages/hw-app-str/src/Str.ts 68.75% <0.00%> (ΓΈ)
...ledgerjs/packages/hw-transport-mocker/src/index.ts
...hw-transport-mocker/src/createTransportReplayer.ts
...s/packages/hw-app-eth/src/services/ledger/erc20.ts
...ledgerjs/packages/hw-app-eth/tests/fixtures/CAL.ts
libs/ledgerjs/packages/hw-app-eth/src/Eth.ts
...js/packages/hw-app-eth/src/modules/EIP712/index.ts
...ages/hw-app-eth/src/modules/EIP712/EIP712.utils.ts
...s/packages/hw-app-eth/src/services/ledger/index.ts
...hw-transport-mocker/src/createTransportRecorder.ts
... and 671 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Nov 18, 2022

@nabil-brn

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@valpinkman
Copy link
Member

Fixed by @elbywan in #1902

@valpinkman valpinkman closed this Nov 22, 2022
@valpinkman valpinkman deleted the support/fix-account-ci branch November 22, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation CI/CD stuff desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants