Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Neo family via Wallet API #2941

Closed
wants to merge 1 commit into from

Conversation

JunichiSugiura
Copy link
Contributor

πŸ“ Description

Support Neo family via Wallet API
Requires: LedgerHQ/wallet-api#131

❓ Context

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2023

πŸ¦‹ Changeset detected

Latest commit: 51c7499

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 14, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated
live-common-tools ❌ Failed (Inspect) Mar 21, 2023 at 11:24AM (UTC)
3 Ignored Deployments
Name Status Preview Comments Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Mar 21, 2023 at 11:24AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Mar 21, 2023 at 11:24AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Mar 21, 2023 at 11:24AM (UTC)

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +11.97 πŸŽ‰

Comparison is base (2b770e6) 53.38% compared to head (4337598) 65.36%.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #2941       +/-   ##
============================================
+ Coverage    53.38%   65.36%   +11.97%     
============================================
  Files           36       90       +54     
  Lines         2246     5390     +3144     
  Branches       464     1046      +582     
============================================
+ Hits          1199     3523     +2324     
- Misses         981     1745      +764     
- Partials        66      122       +56     
Flag Coverage Ξ”
test 65.36% <ΓΈ> (+11.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 54 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@JunichiSugiura
Copy link
Contributor Author

Closing due to #3004 (comment)

@valpinkman valpinkman deleted the feat/#2910-neo-family branch June 23, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant