New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: pnpm v8 update + pnpm-lock update #3070
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest updating all workflows to use a fixed pnpm
version ie. version: 8.0.0
At the moment we have:
steps:
- uses: pnpm/action-setup@v2
with:
version: latest
https://github.com/pnpm/action-setup#just-install-pnpm
Additionally, should consider fixing our node
version to the explicit version set in .nvmrc ie. node-version: 18.15.0
At the moment we have:
- uses: actions/setup-node@v3
with:
node-version: 18
This is to ensure we don't get into the same position next upgrade/update & ensure no regression in builds.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #3070 +/- ##
============================================
+ Coverage 22.36% 65.36% +42.99%
============================================
Files 5 90 +85
Lines 228 5390 +5162
Branches 31 1046 +1015
============================================
+ Hits 51 3523 +3472
- Misses 167 1745 +1578
- Partials 10 122 +112
Flags with carried forward coverage won't be shown. Click here to find out more. see 85 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
We also need to ensure our tools/dev tools work with pnpm 8 |
📝 Description
❓ Context
*
n/a
✅ Checklist
📸 Demo
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.