Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pnpm v8 update + pnpm-lock update #3070

Closed
wants to merge 1 commit into from
Closed

Conversation

gre
Copy link
Contributor

@gre gre commented Mar 28, 2023

⚠️ PR is not ready. lot of complication on the LLM project.

📝 Description

  • this update pnpm-lock with pnpm v8.
  • it seems like react ui was having one failure in TypeScript (not sure why it relates to pnpm)
  • a cocoapod update seems to be needed too

❓ Context

  • Impacted projects: *
  • Linked resource(s): n/a

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2023

⚠️ No Changeset found

Latest commit: 7c245e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
live-common-tools ❌ Failed (Inspect) Mar 28, 2023 at 11:34AM (UTC)
native-ui-storybook ❌ Failed (Inspect) Mar 28, 2023 at 11:34AM (UTC)
2 Ignored Deployments
Name Status Preview Comments Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Mar 28, 2023 at 11:34AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Mar 28, 2023 at 11:34AM (UTC)

Copy link
Contributor

@cksanders cksanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest updating all workflows to use a fixed pnpm version ie. version: 8.0.0

At the moment we have:

steps:
      - uses: pnpm/action-setup@v2
        with:
          version: latest

https://github.com/pnpm/action-setup#just-install-pnpm

Additionally, should consider fixing our node version to the explicit version set in .nvmrc ie. node-version: 18.15.0

At the moment we have:

      - uses: actions/setup-node@v3
        with:
          node-version: 18

This is to ensure we don't get into the same position next upgrade/update & ensure no regression in builds.

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: +42.99 🎉

Comparison is base (d8cadc8) 22.36% compared to head (68446fb) 65.36%.

❗ Current head 68446fb differs from pull request most recent head 7c245e2. Consider uploading reports for the commit 7c245e2 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #3070       +/-   ##
============================================
+ Coverage    22.36%   65.36%   +42.99%     
============================================
  Files            5       90       +85     
  Lines          228     5390     +5162     
  Branches        31     1046     +1015     
============================================
+ Hits            51     3523     +3472     
- Misses         167     1745     +1578     
- Partials        10      122      +112     
Flag Coverage Δ
test 65.36% <ø> (+42.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 85 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added the ui Has changes in the design system library label Mar 28, 2023
@gre gre changed the title chore: pnpm-lock update chore: pnpm v8 update + pnpm-lock update Mar 28, 2023
@valpinkman
Copy link
Member

We also need to ensure our tools/dev tools work with pnpm 8

@gre gre closed this Apr 4, 2023
@gre gre deleted the support/pnpm-8 branch August 28, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants