Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Referral): remove entry point on topbar LLD #3298

Merged
merged 4 commits into from May 10, 2023

Conversation

mcayuelas-ledger
Copy link
Contributor

πŸ“ Description

Remove entry point on Topbar of LLD for referral program since we added new entry in side bar and also an entry in Carrousel Banner

❓ Context

  • Impacted projects: live-desktop
  • Linked resource(s): ``

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2023

πŸ¦‹ Changeset detected

Latest commit: 307d2f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ledger-live-desktop Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 25, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
live-common-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 10, 2023 8:46am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) May 10, 2023 8:46am
native-ui-storybook ⬜️ Ignored (Inspect) May 10, 2023 8:46am
react-ui-storybook ⬜️ Ignored (Inspect) May 10, 2023 8:46am

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -10.21 ⚠️

Comparison is base (795983f) 90.71% compared to head (169d986) 80.51%.

❗ Current head 169d986 differs from pull request most recent head 307d2f5. Consider uploading reports for the commit 307d2f5 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #3298       +/-   ##
============================================
- Coverage    90.71%   80.51%   -10.21%     
============================================
  Files           15       16        +1     
  Lines         1099      549      -550     
  Branches       229       97      -132     
============================================
- Hits           997      442      -555     
+ Misses         100       90       -10     
- Partials         2       17       +15     
Flag Coverage Ξ”
test 80.51% <ΓΈ> (-10.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 31 files with indirect coverage changes

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@mcayuelas-ledger
Copy link
Contributor Author

mcayuelas-ledger commented May 5, 2023

@mcayuelas-ledger

Generating screenshots: workflow ended

Jobs status:
❌ - generate-screenshots-windows
βœ… - generate-screenshots-mac
βœ… - generate-screenshots-linux

@mcayuelas-ledger
Copy link
Contributor Author

mcayuelas-ledger commented May 10, 2023

@mcayuelas-ledger

Generating screenshots: workflow ended

Jobs status:
βœ… - generate-screenshots-windows
βœ… - generate-screenshots-mac
βœ… - generate-screenshots-linux

@mcayuelas-ledger mcayuelas-ledger merged commit 67efb7e into develop May 10, 2023
31 of 33 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the feat/remove-entry-referral-topbar branch May 10, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD screenshots Screenshots have been updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants