Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix provideESDTInfo from device #6158

Merged
merged 15 commits into from
Feb 21, 2024
Merged

Fix provideESDTInfo from device #6158

merged 15 commits into from
Feb 21, 2024

Conversation

AlexandruPislariu
Copy link
Contributor

@AlexandruPislariu AlexandruPislariu commented Feb 12, 2024 •
edited by hedi-edelbloute

📝 Description

Fix provideESDTInfo from device

❓ Context

✅ Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@AlexandruPislariu AlexandruPislariu requested a review from a team as a code owner February 12, 2024 12:45
@vercel Vercel
Copy link

vercel bot commented Feb 12, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 9:55am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2024 9:55am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2024 9:55am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2024 9:55am

@vercel Vercel
Copy link

vercel bot commented Feb 12, 2024

@AlexandruPislariu is attempting to deploy a commit to the LedgerHQ Team on Vercel.

A member of the Team first needs to authorize it.

@live-github-bot live-github-bot bot added desktop Has changes in LLD common Has changes in live-common fork Pull request base branch comes from a fork. labels Feb 12, 2024
@live-github-bot live-github-bot bot added the ledgerjs Has changes in the ledgerjs open source libs label Feb 12, 2024
@AlexandruPislariu AlexandruPislariu marked this pull request as draft February 14, 2024 11:45
@AlexandruPislariu AlexandruPislariu marked this pull request as ready for review February 15, 2024 13:49
@lambertkevin lambertkevin merged commit 1ff3df1 into LedgerHQ:develop Feb 21, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedi-edelbloute hedi-edelbloute hedi-edelbloute approved these changes

Assignees

@AlexandruPislariu AlexandruPislariu

Labels
common Has changes in live-common desktop Has changes in LLD fork Pull request base branch comes from a fork. ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AlexandruPislariu @hedi-edelbloute @lambertkevin @MiroMargineanu