Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix(LIVE-11047): swap llm issue when trying to swap from sol with delegated account #6197

Merged
merged 2 commits into from Feb 15, 2024
Merged

bugfix(LIVE-11047): swap llm issue when trying to swap from sol with delegated account #6197

merged 2 commits into from Feb 15, 2024

Conversation

cng-ledger
Copy link
Contributor

@cng-ledger cng-ledger commented Feb 14, 2024 •
edited

📝 Description

Show Spendable account balance in swap account selection in LLM

Before After
Simulator Screenshot - iPhone SE (3rd generation) - 2024-02-15 at 15 07 58 Simulator Screenshot - iPhone SE (3rd generation) - 2024-02-15 at 15 05 40

❓ Context

✅ Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@cng-ledger cng-ledger requested a review from a team as a code owner February 14, 2024 14:18
@vercel Vercel
Copy link

vercel bot commented Feb 14, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2024 2:22pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2024 2:22pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2024 2:22pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2024 2:22pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2024 2:22pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Feb 14, 2024
CremaFR
CremaFR reviewed Feb 14, 2024
View reviewed changes
Copy link
Member

@CremaFR CremaFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May you provide screenshots of the change?

@cng-ledger
Copy link
Contributor Author

May you provide screenshots of the change?

Screenshot attached to PR

@cng-ledger cng-ledger merged commit e8e74a7 into develop Feb 15, 2024
38 of 45 checks passed
@cng-ledger cng-ledger deleted the bugfix/LIVE-11047-swap-llm-issue-when-trying-to-swap-from-sol-with-delegated-account branch February 15, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CremaFR CremaFR CremaFR left review comments

@sarneijim sarneijim sarneijim approved these changes

Assignees

@cng-ledger cng-ledger

Labels
mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cng-ledger @CremaFR @sarneijim