Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sunset implicitMigration #6585

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

gre
Copy link
Contributor

@gre gre commented Mar 29, 2024

โœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes: very old accounts will have to be reimported

๐Ÿ“ Description

in context of #6534
and for tech debt simplification, we remove the mechanism involving implicitMigration that was used back in 2020 to automatically migrate from libcore accounts to js accounts. Some years have past and we can drop this mechanism, worse case scenario is that users coming back from 2020 will have to reimport their accounts.

โ“ Context

  • JIRA or GitHub link:

๐Ÿง Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@gre gre requested a review from a team as a code owner March 29, 2024 14:41
Copy link

vercel bot commented Mar 29, 2024

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
web-tools โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Mar 29, 2024 2:47pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs โฌœ๏ธ Ignored (Inspect) Mar 29, 2024 2:47pm
ledger-live-github-bot โฌœ๏ธ Ignored (Inspect) Mar 29, 2024 2:47pm
native-ui-storybook โฌœ๏ธ Ignored (Inspect) Mar 29, 2024 2:47pm
react-ui-storybook โฌœ๏ธ Ignored (Inspect) Mar 29, 2024 2:47pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common labels Mar 29, 2024
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub โ†—๏ธŽ

Package New capabilities Transitives Size Publisher
npm/@azure/core-asynciterator-polyfill@1.0.2 None 0 6.51 kB azure-sdk
npm/@babel/core@7.22.8 environment, filesystem, unsafe +24 9.74 MB nicolo-ribaudo
npm/@babel/core@7.23.2 environment, filesystem, unsafe +24 9.75 MB nicolo-ribaudo
npm/@babel/generator@7.17.10 Transitive: environment +3 2.65 MB nicolo-ribaudo
npm/@babel/plugin-proposal-class-properties@7.16.7 Transitive: environment +18 7.16 MB nicolo-ribaudo
npm/@babel/plugin-proposal-export-namespace-from@7.16.7 None +2 28 kB nicolo-ribaudo
npm/@babel/plugin-transform-class-static-block@7.23.4 Transitive: environment +17 7.07 MB nicolo-ribaudo
npm/@babel/preset-env@7.17.10 environment +87 15.2 MB nicolo-ribaudo
npm/@babel/preset-react@7.16.7 Transitive: environment +12 5.05 MB nicolo-ribaudo
npm/@babel/preset-react@7.22.15 Transitive: environment +9 5.03 MB nicolo-ribaudo
npm/@babel/preset-react@7.23.3 Transitive: environment +11 5.04 MB nicolo-ribaudo
npm/@babel/preset-typescript@7.23.3 Transitive: environment +20 7.16 MB nicolo-ribaudo
npm/@babel/runtime@7.17.9 None 0 173 kB nicolo-ribaudo
npm/@babel/runtime@7.22.10 None 0 282 kB nicolo-ribaudo
npm/@braze/react-native-sdk@8.0.0 None 0 252 kB appboy
npm/@braze/web-sdk@4.6.3 None 0 415 kB appboy
npm/@cardano-foundation/ledgerjs-hw-app-cardano@6.0.1 None 0 633 kB jan.mazak
npm/@celo/connect@3.0.1 None +1 321 kB alecps
npm/@celo/contractkit@3.0.1 filesystem, network +2 3.17 MB alecps
npm/@celo/utils@3.0.1 None +1 700 kB alecps
npm/@celo/wallet-base@3.0.1 None +1 252 kB alecps
npm/@celo/wallet-ledger@3.0.1 None +2 287 kB alecps
npm/@changesets/changelog-github@0.5.0 Transitive: environment, network +2 98 kB changesets-release-bot
npm/@changesets/cli@2.26.0 environment, filesystem, shell +16 1.12 MB changesets-release-bot
npm/@commitlint/cli@17.4.4 Transitive: environment, filesystem +15 279 kB escapedcat
npm/@commitlint/config-conventional@17.6.7 None 0 9.6 kB escapedcat
npm/@commitlint/prompt-cli@17.4.4 Transitive: environment +7 155 kB escapedcat
npm/@cosmjs/amino@0.31.1 None +4 302 kB webmaster128
npm/@cosmjs/crypto@0.31.0 None +3 213 kB webmaster128
npm/@cosmjs/stargate@0.26.6 Transitive: network +11 2.98 MB webmaster128
npm/@craftamap/esbuild-plugin-html@0.6.1 filesystem 0 26.7 kB craftamap
npm/@crypto-org-chain/chain-jslib@1.1.2 Transitive: network +22 10.5 MB calvinaco
npm/@dfinity/agent@0.21.4 network 0 1.27 MB krpeacock
npm/@dfinity/candid@0.21.4 None 0 647 kB krpeacock
npm/@dfinity/principal@0.15.6 None 0 140 kB krpeacock
npm/@electron/notarize@2.3.0 filesystem, shell 0 64.5 kB electron-cfa
npm/@elrondnetwork/erdjs-network-providers@1.2.0 None 0 179 kB andreibancioiu
npm/@elrondnetwork/erdjs@11.0.0 None +1 629 kB lucian.mincu
npm/@emotion/core@11.0.0 environment 0 17.1 kB emotion-release-bot
npm/@emotion/native@11.11.0 environment +1 75.3 kB emotion-release-bot
npm/@ethersproject/abi@5.6.1 Transitive: network +19 1.86 MB ricmoo
npm/@ethersproject/rlp@5.6.0 None +2 180 kB ricmoo
npm/@ethersproject/shims@5.7.0 None 0 452 kB ricmoo

๐Ÿšฎ Removed packages: npm/@types/node@20.11.30, npm/camelcase@6.3.0, npm/chalk@4.1.2, npm/cross-env@7.0.3, npm/debug@4.3.4, npm/execa@8.0.1, npm/imurmurhash@0.1.4, npm/lodash@4.17.21, npm/mkdirp@1.0.4, npm/prop-types@15.8.1, npm/regenerator-runtime@0.14.0, npm/semver@7.5.4, npm/semver@7.6.0, npm/tree-kill@1.2.2, npm/tslib@2.6.2, npm/tsx@4.7.1, npm/typescript@5.3.3

View full reportโ†—๏ธŽ

@gre gre merged commit 5a0a1aa into develop Mar 29, 2024
60 checks passed
@gre gre deleted the support/sunset-implicitMigration branch March 29, 2024 16:12
Copy link

sentry-io bot commented Apr 4, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • โ€ผ๏ธ Error: currency with id "arbitrum_goerli" not found getCryptoCurrencyById(libs/ledgerjs/packages/cr... View Issue

Did you find this useful? React with a ๐Ÿ‘ or ๐Ÿ‘Ž

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants