Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(llm): remove hardcoded recover card and add content card component to my ledger page #6593

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Apr 2, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • My Ledger screen
    • Braze content cards

πŸ“ Description

Remove the hardcoded recover card from my ledger to replace it by a braze content card.
Creating a hero card on braze we retrieve the same UI as before

image

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@LucasWerey LucasWerey requested review from a team as code owners April 2, 2024 12:43
@LucasWerey LucasWerey self-assigned this Apr 2, 2024
Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Apr 2, 2024 0:43am
ledger-live-github-bot ⬜️ Ignored (Inspect) Apr 2, 2024 0:43am
native-ui-storybook ⬜️ Ignored (Inspect) Apr 2, 2024 0:43am
react-ui-storybook ⬜️ Ignored (Inspect) Apr 2, 2024 0:43am
web-tools ⬜️ Ignored (Inspect) Apr 2, 2024 0:43am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Apr 2, 2024
Copy link
Contributor

@aussedatlo aussedatlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ‘

@LucasWerey LucasWerey merged commit b6bae9e into develop Apr 3, 2024
60 of 66 checks passed
@LucasWerey LucasWerey deleted the feat/LIVE-11955 branch April 3, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants