Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/LIVE-12088]: remove max toggle button from swap LLM #6628

Merged
merged 5 commits into from
Apr 12, 2024

Conversation

kallen-ledger
Copy link
Contributor

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

  • Remove max toggle button from swap LLM
  • Add detox test check

❓ Context

https://ledgerhq.atlassian.net/browse/LIVE-12088


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@kallen-ledger kallen-ledger requested review from a team as code owners April 8, 2024 10:46
Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 8:10am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 8:10am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 8:10am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 8:10am
web-tools ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 8:10am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Apr 8, 2024
@kallen-ledger kallen-ledger force-pushed the feat/LIVE-12088 branch 2 times, most recently from 503b145 to 2b0dcc3 Compare April 10, 2024 08:29
@kallen-ledger kallen-ledger merged commit da68689 into develop Apr 12, 2024
35 checks passed
@kallen-ledger kallen-ledger deleted the feat/LIVE-12088 branch April 12, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants