feat(lld-llm): Privacy enhancement for braze CC #6629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
live-github-bot
bot
added
desktop
LucasWerey
force-pushed
the
feat/LIVE-11944
branch
from
3d0dfc5
to
b3f3d3c
Compare
LucasWerey
force-pushed
the
feat/LIVE-11944
branch
from
eab7e36
to
ee66678
Compare
LucasWerey
force-pushed
the
feat/LIVE-11944
branch
from
ee66678
to
a94ac9e
Compare
LucasWerey
force-pushed
the
feat/LIVE-11944
branch
from
a94ac9e
to
5643a2e
Compare
LucasWerey
force-pushed
the
feat/LIVE-11944
branch
from
5643a2e
to
43821fc
Compare
LucasWerey
force-pushed
the
feat/LIVE-11944
branch
from
43821fc
to
06d1337
Compare
LucasWerey
force-pushed
the
feat/LIVE-11944
branch
from
06d1337
to
54d5b38
Compare
LucasWerey
force-pushed
the
feat/LIVE-11944
branch
from
54d5b38
to
b7f9baa
Compare
LucasWerey
force-pushed
the
feat/LIVE-11944
branch
from
b7f9baa
to
c1f7469
Compare
…o feat/LIVE-11944
…o feat/LIVE-11944
cgrellard-ledger
previously approved these changes
Apr 18, 2024
LucasWerey
force-pushed
the
feat/LIVE-11944
branch
from
a180226
to
459df4f
Compare
LucasWerey
force-pushed
the
feat/LIVE-11944
branch
from
459df4f
to
14d487c
Compare
…o feat/LIVE-11944
cgrellard-ledger
previously approved these changes
Apr 19, 2024
|
Generating screenshots: workflow ended Jobs status: |
cgrellard-ledger
approved these changes
Apr 19, 2024
alalmi-ledger
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Privacy enhancement for braze CC with untracked users
We will be able to send untracked CC to users who don't want to be tracked. For this we use a redux store so the dismissed CC won't be shown. As we can't track the user id we will assign an id from a pool to the current user.
To test it you can use two different devices and set the same braze user id. If analytics are enabled the cards dismissed on one device will be dismissed on the second. If analytics are disabled it will only dismiss cards on the corresponding device.
Fix braze carousel: it was sliding to an empty CC when there was only 1 CC in the carousel after a dismiss.
Small fix with unimported in common & screenshot causing CI to fail
llm demo : https://github.com/LedgerHQ/ledger-live/assets/73439207/e0fd35f6-86fb-4d85-b6d2-9e1f86fe9620
lld demo : https://github.com/LedgerHQ/ledger-live/assets/73439207/73dbedaa-bacf-436e-8f37-f6334bee9799
❓ Context
🧐 Checklist for the PR Reviewers