Feat/live 10716 focus app when modal open #6632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
live-github-bot
bot
added
desktop
RamyEB
force-pushed
the
feat/LIVE-10716-focus-app-when-modal-open
branch
from
797c027
to
6c50352
Compare
Justkant
requested changes
Apr 9, 2024
Comment on lines
17
to
19
| useEffect(() => { | ||
| ipcRenderer.send("ready-to-show", {}); | ||
| }, []); |
There was a problem hiding this comment.
It would be better to make our own show handler on main because ready-to-show will trigger a deeplink for windows and linux.
ipcMain.on("show", () => {
const w = getMainWindow();
if (w) {
show(w);
}
});Also it would be good to do the logic in the wallet-api part so that we show LLD on any message that requires an action from the user
Justkant
approved these changes
Apr 11, 2024
cgrellard-ledger
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Focus on Ledger Live when modal opens
JIRA TICKET
❓ Context
🧐 Checklist for the PR Reviewers