✨ LLM / LLD - Europa PostOnboarding #6646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
live-github-bot
bot
added
mobile
cgrellard-ledger
changed the title
cgrellard-ledger
changed the title
apps/ledger-live-desktop/src/renderer/components/PostOnboardingHub/logic/index.tsx
Outdated
Show resolved
Hide resolved
ofreyssinet-ledger
previously approved these changes
Apr 12, 2024
LucasWerey
reviewed
Apr 16, 2024
apps/ledger-live-mobile/src/screens/PostOnboarding/PostOnboardingHub.tsx
Outdated
Show resolved
Hide resolved
...e-desktop/tests/specs/market/market.spec.ts-snapshots/market-page-thb-countervalue-linux.png
Outdated
Show resolved
Hide resolved
...live-desktop/src/renderer/screens/settings/sections/Experimental/PostOnboardingHubTester.tsx
Outdated
Show resolved
Hide resolved
… recover entry point
cgrellard-ledger
force-pushed
the
feat/llm-europa-postonboarding
branch
from
2dfc4bb
to
f1b8480
Compare
jdabbech-ledger
previously approved these changes
Apr 18, 2024
alalmi-ledger
previously approved these changes
Apr 18, 2024
|
@cgrellard-ledger Checked on LLM and LLD, QA OK 👍 |
Justkant
reviewed
Apr 18, 2024
Comment on lines
+47
to
+53
| const initIsActionCompleted = useCallback(async () => { | ||
| setIsActionCompleted(completed || !!(await getIsAlreadyCompleted?.({ protectId }))); | ||
| }, [setIsActionCompleted, completed, getIsAlreadyCompleted, protectId]); | ||
|
|
||
| useEffect(() => { | ||
| initIsActionCompleted(); | ||
| }, [initIsActionCompleted]); |
There was a problem hiding this comment.
Do you really want to re-run the init if some dep changed ?
There was a problem hiding this comment.
It makes sense to recompute the isActionCompleted state if a prop changes for some reason
There was a problem hiding this comment.
Ok it just felt weird to call multiple times a function called init
apps/ledger-live-desktop/src/renderer/components/PostOnboardingHub/PostOnboardingActionRow.tsx
Show resolved
Hide resolved
| @@ -29,7 +29,7 @@ export default function RecoverBanner({ children }: { children?: React.ReactNode | |||
| const recoverServices = useFeature("protectServicesDesktop"); | |||
|
|
|||
| const recoverBannerIsEnabled = recoverServices?.params?.bannerSubscriptionNotification; | |||
| const protectID = recoverServices?.params?.protectId ?? ""; | |||
| const protectID = recoverServices?.params?.protectId ?? "protect-prod"; | |||
There was a problem hiding this comment.
We should probably have a constant for protect-prod as I see it repeated multiple times
There was a problem hiding this comment.
Agreed 👍 , maybe a subject for the recover team though
apps/ledger-live-mobile/src/components/PostOnboarding/PostOnboardingActionRow.tsx
Show resolved
Hide resolved
Comment on lines
157
to
159
| useEffect(() => { | ||
| completeAction(PostOnboardingActionId.assetsTransfer); | ||
| }, [completeAction]); |
There was a problem hiding this comment.
Same question as other useEffect do we want to call this only onMount or whenever completeAction changes too ?
There was a problem hiding this comment.
I'll update this one to make sure we do not call this one again in case the completeAction changes
cgrellard-ledger
dismissed stale reviews from alalmi-ledger and jdabbech-ledger
via
504fe50
Justkant
previously approved these changes
Apr 18, 2024
Justkant
approved these changes
Apr 18, 2024
mcayuelas-ledger
approved these changes
Apr 18, 2024
jdabbech-ledger
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Added europa support to post onboarding on both LLM and LLD
Updated post onboarding copy and analytics
Added an entry point to recover in the post onboarding
Updated the design of the Post onboarding banner on LLD
❓ Context
🧐 Checklist for the PR Reviewers