Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: exchangeModule triggers error drawer #6654

Merged
merged 7 commits into from
Apr 17, 2024
Merged

feat: exchangeModule triggers error drawer #6654

merged 7 commits into from
Apr 17, 2024

Conversation

CremaFR
Copy link
Member

@CremaFR CremaFR commented Apr 11, 2024 •
edited

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Moved errors from swap-live-app to exchange module in order to have the same behavior between Moonpay and swap-live-app

❓ Context

- 12020:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@CremaFR CremaFR requested review from a team as code owners April 11, 2024 08:17
@vercel Vercel
Copy link

vercel bot commented Apr 11, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 2:49pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 2:49pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 2:49pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 2:49pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 2:49pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD common Has changes in live-common mobile Has changes in LLM labels Apr 11, 2024
@CremaFR CremaFR force-pushed the chore/error-exchange-module branch from eb1fd3e to c243be3 Compare April 12, 2024 08:08
sprohaszka-ledger
sprohaszka-ledger reviewed Apr 12, 2024
View reviewed changes
Copy link
Contributor

@sprohaszka-ledger sprohaszka-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one quick comment

libs/ledger-live-common/src/exchange/swap/types.ts Outdated Show resolved Hide resolved
sprohaszka-ledger
sprohaszka-ledger approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@sprohaszka-ledger sprohaszka-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CremaFR CremaFR merged commit d9d8902 into develop Apr 17, 2024
54 of 55 checks passed
@CremaFR CremaFR deleted the chore/error-exchange-module branch April 17, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpellizzari-ledger cpellizzari-ledger cpellizzari-ledger approved these changes

@sprohaszka-ledger sprohaszka-ledger sprohaszka-ledger approved these changes

Assignees

@CremaFR CremaFR

Labels
common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CremaFR @cpellizzari-ledger @sprohaszka-ledger