Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/inconsistent punctuation error message #6657

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

sarneijim
Copy link
Contributor

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

nconsistent punctuation in error message.
it has been fixed in LLD and LLM

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2024 3:37pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2024 3:37pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2024 3:37pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2024 3:37pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2024 3:37pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched labels Apr 11, 2024
@sarneijim sarneijim requested a review from a team April 11, 2024 10:51
kallen-ledger
kallen-ledger previously approved these changes Apr 11, 2024
@sarneijim
Copy link
Contributor Author

sarneijim commented Apr 11, 2024

@sarneijim

Generating screenshots: workflow ended

Jobs status:
❌ - generate-screenshots-linux

@sarneijim sarneijim merged commit b129df5 into develop Apr 12, 2024
43 of 45 checks passed
@sarneijim sarneijim deleted the bugfix/inconsistent-punctuation-error-message branch April 12, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants