Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡: [FEAT] - Add Spam report functionality in LLD #6667

Merged
merged 9 commits into from
Apr 16, 2024

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Apr 12, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

To compensate for certain situations where NFTs do not appear in the Gallery because they are considered to be spam, they can now be marked as Non Spam.

It is also possible to mark an NFT and report it as Spam. Both are possible.

3 options :

  • Spam report for an individual NFT
  • Spam report for a contract
  • Spam report for a collection

Display of fields is conditioned with type of report you choose

Following SimpleHash doc (https://docs.simplehash.com/reference/send-spam-report)
Using also useMutation from Tanstack (https://tanstack.com/query/latest/docs/framework/react/reference/useMutation)

Screen.Recording.2024-04-12.at.16.48.03.mov
Screen.Recording.2024-04-12.at.17.13.34.mov

FF demo

Screen.Recording.2024-04-16.at.13.58.21.mov

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@mcayuelas-ledger mcayuelas-ledger requested a review from a team as a code owner April 12, 2024 15:24
Copy link

vercel bot commented Apr 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ❌ Failed (Inspect) Apr 16, 2024 1:04pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 1:04pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 1:04pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 1:04pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 1:04pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD translations Translation files have been touched labels Apr 12, 2024
url,
headers: {
accept: "application/json",
"X-API-KEY": "sh_sk1_Z4jhWXXBE09em",
Copy link
Contributor

@sshmaxime sshmaxime Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we get getEnv the api key X-API-KEY ?

@mcayuelas-ledger
Copy link
Contributor Author

mcayuelas-ledger commented Apr 15, 2024

@mcayuelas-ledger

Generating screenshots: workflow ended

Jobs status:
❌ - generate-screenshots-linux

@mcayuelas-ledger mcayuelas-ledger requested a review from a team as a code owner April 15, 2024 09:33
@live-github-bot live-github-bot bot added the screenshots Screenshots have been updated label Apr 15, 2024
@live-github-bot live-github-bot bot added common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs labels Apr 16, 2024
KVNLS
KVNLS previously approved these changes Apr 16, 2024
Copy link
Member

@KVNLS KVNLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

@mcayuelas-ledger mcayuelas-ledger merged commit 9f90797 into develop Apr 16, 2024
52 of 55 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the feat/beta-nfts-spam-report branch April 16, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants