Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIVE-10249] Bugfix - Cardano invalid data supplied #6682

Merged
merged 10 commits into from
Apr 18, 2024

Conversation

lambertkevin
Copy link
Contributor

@lambertkevin lambertkevin commented Apr 16, 2024

📝 Description

Based on #6515 by @pavanvora and validated by @hedi-edelbloute

Fixed Invalid data supplied to Ledger.
Cardano was passing empty inputs to ledger in some special scenario which was throwing error.
image

❓ Context

✅ Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 5:10pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 5:10pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 5:10pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 5:10pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 5:10pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common labels Apr 16, 2024
@lambertkevin lambertkevin force-pushed the bugfix/cardano-invalid-data-supplied branch from 8f2e6cb to 9041b52 Compare April 16, 2024 10:41
@lambertkevin lambertkevin changed the title Bugfix/cardano invalid data supplied [LIVE-10249] Bugfix - Cardano invalid data supplied Apr 16, 2024
@lambertkevin lambertkevin marked this pull request as ready for review April 16, 2024 10:42
@lambertkevin lambertkevin requested a review from a team as a code owner April 16, 2024 10:42
@lambertkevin lambertkevin mentioned this pull request Apr 16, 2024
9 tasks
lvndry
lvndry previously approved these changes Apr 16, 2024
@lambertkevin lambertkevin force-pushed the bugfix/cardano-invalid-data-supplied branch 2 times, most recently from 8fadcc0 to a6e3303 Compare April 17, 2024 17:08
@lambertkevin lambertkevin merged commit 10df676 into develop Apr 18, 2024
51 of 55 checks passed
@lambertkevin lambertkevin deleted the bugfix/cardano-invalid-data-supplied branch April 18, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants