🐛 [LIVE-12015] [LLD/LLM] Prevent the screen from locking for firmware update and app installation/update #6698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
jdabbech-ledger
force-pushed
the
bugfix/LIVE-12015-keep-screen-awake
branch
3 times, most recently
from
78ab3f6
to
f228e9e
Compare
jdabbech-ledger
force-pushed
the
bugfix/LIVE-12015-keep-screen-awake
branch
from
f228e9e
to
c53b057
Compare
jdabbech-ledger
changed the title
jdabbech-ledger
force-pushed
the
bugfix/LIVE-12015-keep-screen-awake
branch
from
a005542
to
aceac7d
Compare
mbertin-ledger
previously approved these changes
Apr 19, 2024
|
|
||
| const activateKeepAwake = useCallback(async () => { | ||
| if (Number.isNaN(blockerId.current)) { | ||
| blockerId.current = await ipcRenderer.invoke("activate-keep-screen-awake"); |
There was a problem hiding this comment.
[SHOULD] Use constants for the string key (ie: "activate-keep-screen-awake" and "deactivate-keep-screen-awake")
There was a problem hiding this comment.
any ipc message is defined and used this way in main/setup.ts actually
jdabbech-ledger
force-pushed
the
bugfix/LIVE-12015-keep-screen-awake
branch
3 times, most recently
from
c1e1292
to
7a564e3
Compare
jdabbech-ledger
changed the title
ofreyssinet-ledger
requested changes
Apr 22, 2024
jdabbech-ledger
force-pushed
the
bugfix/LIVE-12015-keep-screen-awake
branch
2 times, most recently
from
b2c70fb
to
80335ee
Compare
apps/ledger-live-desktop/src/renderer/screens/manager/FirmwareUpdate/index.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-desktop/src/renderer/screens/manager/FirmwareUpdate/index.tsx
Outdated
Show resolved
Hide resolved
jdabbech-ledger
force-pushed
the
bugfix/LIVE-12015-keep-screen-awake
branch
from
80335ee
to
167e189
Compare
apps/ledger-live-desktop/src/renderer/screens/manager/FirmwareUpdate/index.tsx
Outdated
Show resolved
Hide resolved
jdabbech-ledger
force-pushed
the
bugfix/LIVE-12015-keep-screen-awake
branch
from
167e189
to
95e152a
Compare
jdabbech-ledger
force-pushed
the
bugfix/LIVE-12015-keep-screen-awake
branch
from
95e152a
to
452cf23
Compare
Wiz Scan Summary
|
- App install inside My Ledger - Firmware Update - Inline App install => DeviceAction Component - Sync Onboarding
- App install inside My Ledger - Firmware Update - Inline App install => DeviceAction Component - Sync Onboarding
jdabbech-ledger
force-pushed
the
bugfix/LIVE-12015-keep-screen-awake
branch
from
452cf23
to
21c196d
Compare
ofreyssinet-ledger
approved these changes
Apr 23, 2024
cgrellard-ledger
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Prevent the screen from locking for firmware update and app installation/update
❓ Context
🧐 Checklist for the PR Reviewers