Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(LLD): add deeplink support in dev mode #6701

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

Justkant
Copy link
Contributor

@Justkant Justkant commented Apr 17, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests. Tested manually in dev
  • Impact of the changes:
    • dev mode only

πŸ“ Description

Add deep-link support in dev mode for LLD using: https://github.com/witcher112/electron-app-universal-protocol-client

If you need to clear the deeplinks association to electron on mac you can use https://github.com/Lord-Kamina/SwiftDefaultApps
Screenshot 2024-04-18 at 10 32 40

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Justkant Justkant self-assigned this Apr 17, 2024
@Justkant Justkant requested a review from a team as a code owner April 17, 2024 15:58
Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Apr 17, 2024 3:58pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Apr 17, 2024 3:58pm
native-ui-storybook ⬜️ Ignored (Inspect) Apr 17, 2024 3:58pm
react-ui-storybook ⬜️ Ignored (Inspect) Apr 17, 2024 3:58pm
web-tools ⬜️ Ignored (Inspect) Apr 17, 2024 3:58pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Apr 17, 2024
Copy link

New dependencies detected. Learn more about Socket for GitHub β†—οΈŽ

Package New capabilities Transitives Size Publisher
npm/electron-app-universal-protocol-client@1.3.0 filesystem, shell Transitive: environment +3 1.08 MB witcher112

View full reportβ†—οΈŽ

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub β†—οΈŽ

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/electron-app-universal-protocol-client@1.3.0
  • Install script: install
  • Source: echo 'Using prebuilds'

View full reportβ†—οΈŽ

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/electron-app-universal-protocol-client@1.3.0

Copy link
Contributor

@cksanders cksanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super!

Copy link
Member

@KVNLS KVNLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Justkant Justkant merged commit a99bc72 into develop Apr 18, 2024
53 of 54 checks passed
@Justkant Justkant deleted the support/lld-dev-deeplink branch April 18, 2024 08:12
@Justkant
Copy link
Contributor Author

If you need to clear the deeplinks association to electron on mac you can use https://github.com/Lord-Kamina/SwiftDefaultApps
Screenshot 2024-04-18 at 10 32 40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants