[Support/Filecoin] Add ERC20 tokens support for Filecoin #6704

lawRathod · 2024-04-17T17:39:16Z

✅ Checklist

npx changeset was attached.
Covered by automatic tests.
Impact of the changes:
- ...

📝 Description

Add ERC20 token support for filecoin network. Adds new tokens specific to filecoin and enable send/receive.

❓ Context

JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

vercel · 2024-04-17T17:39:22Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
web-tools	❌ Failed (Inspect)			Jun 4, 2024 11:21am

3 Ignored Deployments

Name	Status	Preview	Updated (UTC)
ledger-live-docs	⬜️ Ignored (Inspect)	Visit Preview	Jun 4, 2024 11:21am
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Jun 4, 2024 11:21am
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Jun 4, 2024 11:21am

vercel · 2024-04-17T17:39:23Z

@lawRathod is attempting to deploy a commit to the LedgerHQ Team on Vercel.

A member of the Team first needs to authorize it.

github-actions · 2024-05-22T04:25:25Z

There as been no activity on this PR for the last 14 days. Please consider closing this PR.

hzheng-ledger · 2024-05-29T08:04:48Z

libs/ledger-live-common/src/families/filecoin/bridge/utils/addresses.ts

+
+  const accountType = addr.substring(0, 2);
+  if (["f0", "0x", "f4"].includes(accountType)) {
+    return true;


if I understand correctly, an address begins with "f0" or "f4", we should convert them into eth address and check whether it is a valid one. right?
we can't consider all the addresses begin with "f0" or "f4" are valid. right?

what if an address begins with "f1", is it valid?

you understand correct, for token transfer we need the address to be eth style (0x) not f[0,1,4]. In filecoin ecosystem there's ways to convert all native addresses to eth style but f1 is exception which requires network call (insecure) to get equivalent f0 and then f0 -> 0x (secure).

For addresses beginning with f1 we do not want to support them for token transfer because network call can be insecure in practice and lead to possible known attacks. For when invalid we therefore have this error.

hzheng-ledger · 2024-05-29T13:09:10Z

libs/ledger-live-common/package.json

@@ -240,6 +242,7 @@
    "tsx": "^4.7.1",
    "usehooks-ts": "^2.13.0",
    "utility-types": "^3.10.0",
+    "web3": "^4.7.0",


we use
the "ethers" lib instead of "web3" in our codebase.

i.e.
https://github.com/LedgerHQ/ledger-live/blob/develop/libs/coin-modules/coin-evm/package.json#L75

could you plz change it to "ethers" lib to be coherent with the rest of our codebase? Thanks a lot

Definitely, now using ethers instead of web3.

hzheng-ledger · 2024-05-29T13:09:47Z

libs/ledger-live-common/package.json

@@ -131,6 +131,7 @@
    "@elrondnetwork/erdjs": "11.0.0",
    "@elrondnetwork/erdjs-network-providers": "^1.1.2",
    "@hashgraph/sdk": "2.14.2",
+    "@ipld/dag-cbor": "^9.2.0",


I don't find it is used in the current code. Isn't it?

It's definitely not, now removed from package.json... it was an accident 😅

hzheng-ledger · 2024-05-29T13:16:25Z

libs/ledger-live-common/src/families/filecoin/bridge/utils/erc20/tokenAccounts.ts

+  const buffer = Buffer.from(abiEncodedParams.slice(2), "hex"); // buffer/byte array
+  const dataEncoded = cbor.encode(buffer);
+
+  return base64.stringify(dataEncoded);


I think we can use
Buffer.from
and
buffer.toString('base64');

instead, so that we don't have to use "rfc4648" lib

Great tip, I didn't know it could be done this way. Now using this way and the rfc4648 is removed from the package.json. 😄

hzheng-ledger · 2024-05-29T13:25:10Z

apps/ledger-live-desktop/static/i18n/en/app.json

@@ -5495,6 +5495,9 @@
      "title": "Impossible to calculate amount and fees",
      "description": "Impossible to calculate amount and fees"
    },
+    "InvalidRecipientForTokenTransfer": {


should we do the same translation for Ledger Mobile?

Yes definitely, I am sorry it wasn't there but now I have added it.

hzheng-ledger · 2024-05-29T14:12:54Z

libs/ledger-live-common/src/families/filecoin/bridge/utils/erc20/tokenAccounts.ts

+      const bnBalance = new BigNumber(balance.toString());
+      const tokenAccountId = encodeTokenAccountId(parentAccountId, token);
+
+      const operations = txns


Just a question: For the subaccount operations, are all the addresses retrieved from the explorer endpoint expressed in the Ethereum format instead of the Filecoin format?

If a user clicks the "receive" button, does he get an Ethereum format address or a Filecoin format address?

Do you think it is better to convert back to the Filecoin format in the UI? If a user sends ERC20 tokens using his Filecoin account in the UI, I think he expects to see his Filecoin address as the sender in the operation list.

For the subaccount operations, are all the addresses retrieved from the explorer endpoint expressed in the Ethereum format instead of the Filecoin format?

Yes they are, the erc20 endpoints on indexing only stores the address data from the evm world. The translation isn't yet there.

If a user clicks the "receive" button, does he get an Ethereum format address or a Filecoin format address?

The user will see a filecoin address format with f1 protocol. Converting to f1 -> 0x involves a lookup from node through network call which we think might cause trouble hence the translation isn't supported. More info here

Do you think it is better to convert back to the Filecoin format in the UI?

It's definitely better user experience IMO. It will definitely cost more network calls because going from 0x to f1 might be tricky, the other way is much easier. We already do convert f1 -> 0x to check if the account is sending or receiving, I think it would be okay to override the sender/reciever address at least when creating operations. What do you think?

hzheng-ledger

Please have a look at my comments. Thanks a lot

lawRathod · 2024-05-31T02:10:08Z

Please have a look at my comments. Thanks a lot

Thanks for the review 🙌🏻, I tried to work on the comments. Please have another look when possible.

github-actions bot assigned lawRathod Apr 17, 2024

live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs translations Translation files have been touched fork Pull request base branch comes from a fork. labels Apr 17, 2024

lawRathod force-pushed the support/filecoin-evm branch 2 times, most recently from df6c770 to ceae9ec Compare April 18, 2024 09:14

vercel bot deployed to Preview – web-tools April 19, 2024 13:38 View deployment

lawRathod force-pushed the support/filecoin-evm branch from 0b526f5 to 05418da Compare April 19, 2024 13:54

vercel bot deployed to Preview – web-tools April 19, 2024 14:03 View deployment

lawRathod marked this pull request as ready for review April 19, 2024 14:06

lawRathod requested a review from a team as a code owner April 19, 2024 14:06

lawRathod force-pushed the support/filecoin-evm branch from 05418da to 48e6892 Compare April 22, 2024 12:51

vercel bot deployed to Preview – web-tools April 22, 2024 12:58 View deployment

lawRathod force-pushed the support/filecoin-evm branch from db76776 to 5cf9be4 Compare April 24, 2024 20:24

vercel bot deployed to Preview – web-tools April 24, 2024 20:33 View deployment

lawRathod force-pushed the support/filecoin-evm branch from 5cf9be4 to 0e1c3f1 Compare April 25, 2024 22:39

vercel bot deployed to Preview – web-tools April 25, 2024 22:43 View deployment

lawRathod force-pushed the support/filecoin-evm branch from 0e1c3f1 to 98eb896 Compare April 25, 2024 22:55

vercel bot deployed to Preview – web-tools April 25, 2024 23:01 View deployment

vercel bot deployed to Preview – web-tools May 1, 2024 17:23 View deployment

vercel bot deployed to Preview – web-tools May 1, 2024 19:08 View deployment

lawRathod force-pushed the support/filecoin-evm branch from 1b1cb97 to 7cc3c35 Compare May 6, 2024 16:03

vercel bot deployed to Preview – web-tools May 6, 2024 16:10 View deployment

github-actions bot added the Stale label May 22, 2024

lawRathod force-pushed the support/filecoin-evm branch from 7cc3c35 to 6a1b0ae Compare May 23, 2024 01:35

lawRathod requested a review from a team as a code owner May 23, 2024 01:35

live-github-bot bot added the ui Has changes in the design system library label May 23, 2024

vercel bot deployed to Preview – web-tools May 23, 2024 01:42 View deployment

lawRathod force-pushed the support/filecoin-evm branch from 6a1b0ae to 263cbaf Compare May 27, 2024 17:46

vercel bot deployed to Preview – web-tools May 27, 2024 17:53 View deployment

hzheng-ledger reviewed May 29, 2024

View reviewed changes

hzheng-ledger requested changes May 29, 2024

View reviewed changes

vercel bot deployed to Preview – web-tools May 31, 2024 02:00 View deployment

lawRathod requested a review from hzheng-ledger May 31, 2024 02:08

github-actions bot removed the Stale label May 31, 2024

vercel bot had a problem deploying to Preview – web-tools June 3, 2024 21:49 Failure

lawRathod added 5 commits June 4, 2024 13:05

feat(fil): add erc20 tokens data for filecoin

cf6ebfe

chore(fil): add token icons and remove staked tokens

e32ed57

refac(fil): update logic and minor updates to dependencies

de35282

chore(fil): update logic post refac

bd434bb

tests(fil): update bot tests

5a5ceac

vercel bot had a problem deploying to Preview – web-tools June 4, 2024 11:09 Failure

refac(fil): fixup operation and increase bot tests timeout

a814b1c

lawRathod force-pushed the support/filecoin-evm branch from 4723d93 to a814b1c Compare June 4, 2024 11:15

vercel bot had a problem deploying to Preview – web-tools June 4, 2024 11:21 Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Support/Filecoin] Add ERC20 tokens support for Filecoin #6704

[Support/Filecoin] Add ERC20 tokens support for Filecoin #6704

lawRathod commented Apr 17, 2024

vercel bot commented Apr 17, 2024 •

edited

vercel bot commented Apr 17, 2024

github-actions bot commented May 22, 2024

hzheng-ledger May 29, 2024 •

edited

hzheng-ledger May 29, 2024

lawRathod May 30, 2024

hzheng-ledger May 29, 2024

lawRathod May 31, 2024

hzheng-ledger May 29, 2024

lawRathod May 31, 2024

hzheng-ledger May 29, 2024

lawRathod May 31, 2024

hzheng-ledger May 29, 2024

lawRathod May 31, 2024

hzheng-ledger May 29, 2024

lawRathod May 31, 2024

hzheng-ledger left a comment

lawRathod commented May 31, 2024

[Support/Filecoin] Add ERC20 tokens support for Filecoin #6704

Are you sure you want to change the base?

[Support/Filecoin] Add ERC20 tokens support for Filecoin #6704

Conversation

lawRathod commented Apr 17, 2024

✅ Checklist

📝 Description

❓ Context

🧐 Checklist for the PR Reviewers

vercel bot commented Apr 17, 2024 • edited

vercel bot commented Apr 17, 2024

github-actions bot commented May 22, 2024

hzheng-ledger May 29, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hzheng-ledger left a comment

Choose a reason for hiding this comment

lawRathod commented May 31, 2024

vercel bot commented Apr 17, 2024 •

edited

hzheng-ledger May 29, 2024 •

edited