Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid displaying address field on sign transaction modal #6718

Merged
merged 2 commits into from
Apr 22, 2024
Merged

avoid displaying address field on sign transaction modal #6718

merged 2 commits into from
Apr 22, 2024

Conversation

Wozacosta
Copy link
Contributor

@Wozacosta Wozacosta commented Apr 19, 2024 •
edited

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Reasoning for the changes: to avoid having conflicting informations on LLD and on your ledger, as the screenshot below illustrates:

SCR-20240419-qdje

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bugfixes, you can explain the previous behavior and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Apr 19, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Apr 19, 2024 4:27pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Apr 19, 2024 4:27pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 19, 2024 4:27pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 19, 2024 4:27pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Apr 19, 2024 4:27pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Apr 19, 2024
ComradeAERGO
ComradeAERGO previously approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@ComradeAERGO ComradeAERGO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wozacosta Wozacosta marked this pull request as ready for review April 19, 2024 16:24
@Wozacosta Wozacosta requested a review from a team as a code owner April 19, 2024 16:24
@Wozacosta Wozacosta changed the title test- displayedfields filtered avoid displaying address field on sign transaction modal Apr 22, 2024
@Wozacosta Wozacosta merged commit dbad3c0 into develop Apr 22, 2024
34 of 39 checks passed
@Wozacosta Wozacosta deleted the feat/whitelist-displayed-fields branch April 22, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KVNLS KVNLS KVNLS approved these changes

@ComradeAERGO ComradeAERGO ComradeAERGO approved these changes

@LucasWerey LucasWerey LucasWerey approved these changes

Assignees

@Wozacosta Wozacosta

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Wozacosta @KVNLS @ComradeAERGO @LucasWerey