Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]: Starred coins were not saved anymore since rework #6726

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

mcayuelas-ledger
Copy link
Contributor

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Starred coins were not saved anymore since rework

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@mcayuelas-ledger mcayuelas-ledger requested a review from a team as a code owner April 22, 2024 15:09
Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 3:22pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 3:22pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 3:22pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 3:22pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 3:22pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Apr 22, 2024
gre
gre previously approved these changes Apr 22, 2024
@mcayuelas-ledger mcayuelas-ledger merged commit 9593f88 into develop Apr 22, 2024
32 of 33 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the bugfix/starred-coins-market branch April 22, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants