Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ’„[BUGFIX]: Update NoCryptoPlaceholder Icon on market using right Theme #6736

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

mcayuelas-ledger
Copy link
Contributor

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Update NoCryptoPlaceholder Icon on market using right Theme

Before

Screenshot 2024-04-24 at 14 38 54

After

Screen.Recording.2024-04-24.at.14.39.16.mov

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Apr 24, 2024 0:42am
ledger-live-github-bot ⬜️ Ignored (Inspect) Apr 24, 2024 0:42am
native-ui-storybook ⬜️ Ignored (Inspect) Apr 24, 2024 0:42am
react-ui-storybook ⬜️ Ignored (Inspect) Apr 24, 2024 0:42am
web-tools ⬜️ Ignored (Inspect) Apr 24, 2024 0:42am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Apr 24, 2024
@mcayuelas-ledger mcayuelas-ledger requested a review from a team as a code owner April 24, 2024 12:43
@mcayuelas-ledger mcayuelas-ledger merged commit 882c77d into develop Apr 25, 2024
33 of 35 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the bugfix/wrong-icon-market branch April 25, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants