B2CA-969: Activate pinpad and fix CCID SC_Secure #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #499 +/- ##
=======================================
Coverage 60.18% 60.18%
=======================================
Files 12 12
Lines 1660 1660
=======================================
Hits 999 999
Misses 661 661
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cedelavergne-ledger
force-pushed
the
cev/B2CA-969_ccid-pinpad
branch
2 times, most recently
from
9564251
to
b501382
Compare
cedelavergne-ledger
force-pushed
the
cev/B2CA-969_ccid-pinpad
branch
from
b501382
to
00a5310
Compare
lib_stusb/STM32_USB_Device_Library/Class/CCID/inc/usbd_ccid_if.h
Outdated
Show resolved
Hide resolved
lib_stusb/STM32_USB_Device_Library/Class/CCID/src/usbd_ccid_if.c
Outdated
Show resolved
Hide resolved
cedelavergne-ledger
force-pushed
the
cev/B2CA-969_ccid-pinpad
branch
from
00a5310
to
9a91473
Compare
xchapron-ledger
approved these changes
Jan 12, 2024
lib_stusb/STM32_USB_Device_Library/Class/CCID/src/usbd_ccid_if.c
Outdated
Show resolved
Hide resolved
lib_stusb/STM32_USB_Device_Library/Class/CCID/src/usbd_ccid_if.c
Outdated
Show resolved
Hide resolved
cedelavergne-ledger
force-pushed
the
cev/B2CA-969_ccid-pinpad
branch
from
9a91473
to
440ddc6
Compare
xchapron-ledger
approved these changes
Jan 12, 2024
cedelavergne-ledger
force-pushed
the
cev/B2CA-969_ccid-pinpad
branch
from
440ddc6
to
889d35e
Compare
sportron-ledger
approved these changes
Jan 18, 2024
cedelavergne-ledger
force-pushed
the
cev/B2CA-969_ccid-pinpad
branch
from
889d35e
to
1bdd759
Compare
This was referenced Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
SC_Securefunction because the data parsing was not aligned with CCID spec, and the returned payload caused the app crashingChanges include