This repository has been archived by the owner on Feb 14, 2024. It is now read-only.
Fix for Extended APDUs #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all Java Cards that support extended APDUs have APDU buffer lengths long enough to include the attestation certificate. This causes registration to fail when extended APDUs are used, as is the case with iOS. The fix is to build the extended responses incrementally instead of staging them all at once in the APDU buffer.
darconeous
force-pushed
the
extended-apdu
branch
from
bdcb1d1
to
6bc4f99
Compare
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all Java Cards that support extended APDUs have APDU buffer lengths long enough to include the attestation certificate. This causes registration to fail when extended APDUs are used, as is the case with iOS.
The fix is to build the extended responses incrementally instead of staging them all at once in the APDU buffer.
Note that this fix alone is not enough to enable support for native iOS usage (although it is required to do so). See #12 for more information.